Messages in this thread |  | | Date | Fri, 25 Aug 2017 16:19:39 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when using PPv2.2 |
| |
On Fri, Aug 25, 2017 at 04:14:17PM +0200, Antoine Tenart wrote: > The mac address is only retrieved from h/w when using PPv2.1. Otherwise > the variable holding it is still checked and used if it contains a valid > value. As the variable isn't initialized to an invalid mac address > value, we end up with random mac addresses which can be the same for all > the ports handled by this PPv2 driver. > > Fixes this by initializing the h/w mac address variable to {0}, which is > an invalid mac address value. This way the random assignation fallback > is called and all ports end up with their own addresses. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
Hi Antoine
Is this patch alone sufficient to fix the problem?
Ideally, you want a minimal patch for stable, i.e. -net, and a fuller fix can go into net-next.
Andrew
|  |