[lkml]   [2017]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH v2] irqdomain: potential Oops in irq_domain_push_irq()
This code generates a Smatch warning:

kernel/irq/irqdomain.c:1511 irq_domain_push_irq()
warn: variable dereferenced before check 'root_irq_data' (see line 1508)

irq_get_irq_data() does sometimes return NULL pointers so it does look
like this code could Oops. I've moved the check for NULL earlier to
fix this bug.

Signed-off-by: Dan Carpenter <>
v2: redo the commit message

diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index b9c688944429..e84b7056bb08 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -1505,10 +1505,10 @@ int irq_domain_push_irq(struct irq_domain *domain, int virq, void *arg)
if (WARN_ON(!irq_domain_is_hierarchy(domain)))
return -EINVAL;

- if (domain->parent != root_irq_data->domain)
+ if (!root_irq_data)
return -EINVAL;

- if (!root_irq_data)
+ if (domain->parent != root_irq_data->domain)
return -EINVAL;

child_irq_data = kzalloc_node(sizeof(*child_irq_data), GFP_KERNEL,
 \ /
  Last update: 2017-08-25 11:11    [W:0.026 / U:2.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site