lkml.org 
[lkml]   [2017]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic
    On Wed, Aug 23, 2017 at 1:54 AM, Andrew Jeffery <andrew@aj.id.au> wrote:
    > On Tue, 2017-08-22 at 14:52 +0200, Linus Walleij wrote:
    >> > On Tue, Aug 15, 2017 at 6:21 PM, Yong Li <sdliyong@gmail.com> wrote:
    >>
    >> > On AST2500, the hardware strap register(SCU70) only accepts write ‘1’,
    >> > to clear it to ‘0’, must set bits(write ‘1’) to SCU7C
    >> >
    >> > Signed-off-by: Yong Li <sdliyong@gmail.com>
    >>
    >> Patch applied with Andrew's review/test tags.
    >
    > I realised after I sent the tags on v3 that I'd made a mistake: There's a
    > slightly awkward to test bug in the v3 implementation. I followed up on v3 with
    > this:
    >
    > https://lkml.org/lkml/2017/8/16/905
    >
    > And Yong sent out a corresponding v4:
    >
    > https://patchwork.ozlabs.org/patch/802946/

    Ah. I got confused and picked the wrong version.

    > I see you've pushed Yong's v3 in pinctrl/devel - can we revert/remove that and
    > apply v4?

    No I would have to revert the patch.

    Can't we simply make a small fixup patch?

    Yours,
    Linus Walleij

    \
     
     \ /
      Last update: 2017-08-23 10:24    [W:6.421 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site