Messages in this thread |  | | Subject | Re: [PATCH 2/2] iommu/tegra-gart: Add support for struct iommu_device | From | Dmitry Osipenko <> | Date | Thu, 17 Aug 2017 01:21:52 +0300 |
| |
Hello Joerg,
On 10.08.2017 01:29, Joerg Roedel wrote: > From: Joerg Roedel <jroedel@suse.de> > > Add a struct iommu_device to each tegra-gart and register it > with the iommu-core. Also link devices added to the driver > to their respective hardware iommus. > > Signed-off-by: Joerg Roedel <jroedel@suse.de> > --- > drivers/iommu/tegra-gart.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) >
Reviewed-by: Dmitry Osipenko <digetx@gmail.com> Tested-by: Dmitry Osipenko <digetx@gmail.com>
> diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c > index 29bafc6..b62f790 100644 > --- a/drivers/iommu/tegra-gart.c > +++ b/drivers/iommu/tegra-gart.c
[snip]
> @@ -449,6 +472,9 @@ static int tegra_gart_remove(struct platform_device *pdev) > {
BTW, GART's driver can't be build as a module, so this function is pretty much a dead code. Probably worth considering its removal.
> struct gart_device *gart = platform_get_drvdata(pdev); > > + iommu_device_unregister(&gart->iommu); > + iommu_device_sysfs_remove(&gart->iommu); > + > writel(0, gart->regs + GART_CONFIG); > if (gart->savedata) > vfree(gart->savedata); >
-- Dmitry
|  |