[lkml]   [2017]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Revert "staging: fsl-mc: be consistent when checking strcmp() return"
On Wed, Aug 16, 2017 at 06:12:00PM +0100, Colin King wrote:
> From: Colin Ian King <>
> The previous fix removed the equal to zero comparisons by the strcmps and
> now the function always returns true. Revert this change to restore the
> original correctly functioning code.
> Detected by CoverityScan, CID#1452267 ("Constant expression result")
> This reverts commit b93ad9a067e1515af42da7d56bc61f1a25075f94.

So this should say:


And it should get into 4.13-final, right? Or if not, at least
backported to 4.13-stable?

Can you please resend it with the fixes tag?


greg k-h

 \ /
  Last update: 2017-08-16 19:17    [W:0.028 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site