Messages in this thread |  | | Subject | Re: [PATCH] IB/core: fix memory leak on ah on error return path | From | Doug Ledford <> | Date | Wed, 16 Aug 2017 11:32:37 -0400 |
| |
On Tue, 2017-08-08 at 19:48 +0000, Parav Pandit wrote: > Hi, > > I need to top post because comments are unrelated to past discussion. > > rdma_ah_retrieve_dmac() can never fail for RoCE as its returning > pointer from structure ah_attr. > Provider driver doesn't need to check for null pointer as ib/core > would never call provider if it's not RoCE provider. > So this memory leak only exist in theory. > > When its null, driver should WARN_ON/BUG_ON in extreme case, but > that's not necessary either. > > I have patch is progress under internal review that does nice small > cleanup in many provider drivers that eliminates the check > completely. > Waiting for Moni to finish the review.
This sounds like a nice patch to push into for-next, but in the meantime I took the V2 of this patch as it silences a checker warning.
-- Doug Ledford <dledford@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
|  |