Messages in this thread Patch in this message |  | | Date | Wed, 16 Aug 2017 11:27:35 -0400 | From | Steven Rostedt <> | Subject | [PATCH] completion: Document that reinit_completion() must be called after complete_all() |
| |
The function complete_all() modifies the completion "done" variable to UINT_MAX, and no other caller (wait_for_completion(), etc) will modify it back to zero. That means that any call to complete_all() must have a reinit_completion() before that completion can be used again.
Document this fact by the complete_all() function.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> --- diff --git a/kernel/sched/completion.c b/kernel/sched/completion.c index 13fc5ae..cc9d926 100644 --- a/kernel/sched/completion.c +++ b/kernel/sched/completion.c @@ -47,6 +47,9 @@ EXPORT_SYMBOL(complete); * * It may be assumed that this function implies a write memory barrier before * changing the task state if and only if any tasks are woken up. + * + * A call to reinit_completion() must be used on @x if it is to be used + * again after this call. */ void complete_all(struct completion *x) {
|  |