Messages in this thread |  | | From | "Luck, Tony" <> | Subject | RE: [PATCH] ACPI/APEI: Add BERT data driver | Date | Wed, 16 Aug 2017 15:22:44 +0000 |
| |
> One thing I missed commenting on in the previous version - > > Have you thought of exposing the error records via /sys/firmware/acpi? > The tables are already exposed there and as BERT is part of ACPI > logically that's a better fit compared to a misc device.
That was my first thought :-)
But I got stuck on how to name things. The BERT entry appears in /sys/firmware/acpi/tables/ ... but the code doesn't know anything special about "BERT", it just iterates over all the tables and makes them all appear.
I thought about making it /sys/firmware/acpi/tables/BERT.data, but that seemed very ugly (this file isn't a "table", so why does it appear in the "tables" directory? So maybe /sys/firmware/acpi/table-data/BERT? Now the driver has to make another directory.
Thoughts?
-Tony
|  |