Messages in this thread |  | | Subject | Re: [PATCH v4 1/3] dt-bindings: i2c: Document the IBM CCF power supply version 1 | From | Guenter Roeck <> | Date | Wed, 16 Aug 2017 06:42:43 -0700 |
| |
On 08/15/2017 01:52 PM, Eddie James wrote: > From: "Edward A. James" <eajames@us.ibm.com> > > Signed-off-by: Edward A. James <eajames@us.ibm.com> > --- > .../devicetree/bindings/i2c/ibm,cffps1.txt | 21 +++++++++++++++++++++
Sorry, just noticed. Sorry for the piecemeal review :-(. The i2c directory is used for i2c controllers, not for other i2c devices. Please move to hwmon (and drop i2c from the subject).
Thanks, Guenter
> 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/ibm,cffps1.txt > > diff --git a/Documentation/devicetree/bindings/i2c/ibm,cffps1.txt b/Documentation/devicetree/bindings/i2c/ibm,cffps1.txt > new file mode 100644 > index 0000000..f68a0a6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/ibm,cffps1.txt > @@ -0,0 +1,21 @@ > +Device-tree bindings for IBM Common Form Factor Power Supply Version 1 > +---------------------------------------------------------------------- > + > +Required properties: > + - compatible = "ibm,cffps1"; > + - reg = < I2C bus address >; : Address of the power supply on the > + I2C bus. > + > +Example: > + > + i2c-bus@100 { > + #address-cells = <1>; > + #size-cells = <0>; > + #interrupt-cells = <1>; > + < more properties > > + > + power-supply@68 { > + compatible = "ibm,cffps1"; > + reg = <0x68>; > + }; > + }; >
|  |