Messages in this thread |  | | From | Eugeniy Paltsev <> | Subject | Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver | Date | Wed, 16 Aug 2017 12:52:01 +0000 |
| |
Hi Philipp,
On Wed, 2017-08-16 at 11:46 +0200, Philipp Zabel wrote: > The reset-simple driver can be used without changes. > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > [snip] > > --- a/drivers/reset/reset-simple.c > +++ b/drivers/reset/reset-simple.c > @@ -120,6 +120,7 @@ static const struct reset_simple_devdata > reset_simple_active_low = { > > static const struct of_device_id reset_simple_dt_ids[] = { > { .compatible = "altr,rst-mgr", .data = > &reset_simple_socfpga }, > + { .compatible = "st,stm32-rcc", }, > { .compatible = "allwinner,sun6i-a31-clock-reset", > .data = &reset_simple_active_low }, > { /* sentinel */ },
What about adding generic compatible strings for future use? I mean next:
--------------------->8---------------------
static const struct of_device_id reset_simple_dt_ids[] = { { .compatible = "reset-simple-active-low", .data = &reset_simple_active_low }, { .compatible = "reset-simple-active-high", .data = &reset_simple_active_high }, /* ... */ { /* sentinel */ }, };
static const struct reset_simple_devdata reset_simple_active_high = { .active_low = false, };
static const struct reset_simple_devdata reset_simple_active_low = { .active_low = true, };
--------------------->8---------------------
-- Eugeniy Paltsev |  |