Messages in this thread |  | | Date | Wed, 16 Aug 2017 15:10:14 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps |
| |
On Wed, Aug 16, 2017 at 03:06:54PM +0300, Dan Carpenter wrote: > On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > The previous fix removed the equal to zero comparisons by the strcmps and > > now the function always returns true. Fix this by adding in the missing > > logical negation operators. > > > > Detected by CoverityScan, CID#1452267 ("Constant expression result") > > > > Fixes: b93ad9a067e1 ("staging: fsl-mc: be consistent when checking strcmp() return") > > Ugh... I did review the original patch at all. Sorry.
s/did/did not/
regards, dan carpenter
|  |