Messages in this thread |  | | Date | Wed, 16 Aug 2017 10:31:06 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2 1/4] staging: pi433: Style fix - Correct long lines |
| |
On Wed, Aug 16, 2017 at 10:53:18AM +0530, Rishabh Hardas wrote: > @@ -143,10 +142,13 @@ struct pi433_rx_cfg { > > #define PI433_IOC_MAGIC 'r' > > -#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)]) > -#define PI433_IOC_WR_TX_CFG _IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)]) > - > -#define PI433_IOC_RD_RX_CFG _IOR(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR, char[sizeof(struct pi433_rx_cfg)]) > -#define PI433_IOC_WR_RX_CFG _IOW(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR, char[sizeof(struct pi433_rx_cfg)]) > +#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\ > + char[sizeof(struct pi433_tx_cfg)]) > +#define PI433_IOC_WR_TX_CFG _IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\ > + char[sizeof(struct pi433_tx_cfg)]) > +#define PI433_IOC_RD_RX_CFG _IOR(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR,\ > + char[sizeof(struct pi433_rx_cfg)]) > +#define PI433_IOC_WR_RX_CFG _IOW(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR,\ > + char[sizeof(struct pi433_rx_cfg)])
These don't help readability. The original was better.
regards, dan carpenter
|  |