Messages in this thread |  | | Date | Mon, 14 Aug 2017 21:52:36 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH] i2c: slave-eeprom: Add an OF device ID table |
| |
On Wed, Aug 09, 2017 at 12:12:56PM +0200, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees as shown in the following DT binding doc: > > Documentation/devicetree/bindings/i2c/i2c-designware.txt
Uhhh, that needs to be fixed to something else! I don't think i2c slave functionality should be described in DT. The slave functionality is pure software, so IMO it doesn't match the "HW description" requirement.
> But this works on the assumption that a I2C device registered via OF will > always match a legacy I2C device ID and that the MODALIAS reported will > always be of the form i2c:<device>. > > And this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks for finding the issue, still NAK to this patch. Are you interested in updating the docs?
[unhandled content-type:application/pgp-signature] |  |