[lkml]   [2017]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [[PATCH v1] 12/37] [CIFS] SMBD: Handle send completion from CQ

> -----Original Message-----
> From: Christoph Hellwig []
> Sent: Sunday, August 13, 2017 3:20 AM
> To: Long Li <>
> Cc: Steve French <>;; samba-
>;; Long Li
> <>
> Subject: Re: [[PATCH v1] 12/37] [CIFS] SMBD: Handle send completion from
> CQ
> You seem to be doing memory allocations and frees for every packet on the
> write. At least for other RDMA protocols that would have been a major
> performance issue.

The size of SGE array passed to IB is unknown, so I don't know how much to pre-allocate in advance. But it seems this size is not big when passed down from CIFS. I will look at pre-allocating buffer if this is an issue.

> Do you have any performance numbers and/or profiles of the code?

I will look into profiling.

 \ /
  Last update: 2017-08-14 20:17    [W:0.078 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site