| Date | Sun, 13 Aug 2017 03:11:56 -0700 | From | Christoph Hellwig <> | Subject | Re: [[PATCH v1] 04/37] [CIFS] SMBD: Define per-channel SMBD transport parameters and default values |
| |
> +/* > + * Per RDMA transport connection parameters > + * as defined in [MS-SMBD] 3.1.1.1 > + */ > +static int receive_credit_max = 512; > +static int send_credit_target = 512; > +static int max_send_size = 8192; > +static int max_fragmented_recv_size = 1024*1024; > +static int max_receive_size = 8192;
Are these protocol constants? If so please use either #defines or enums with upper case names for them.
> +// maximum number of SGEs in a RDMA I/O
Please always use /* ... */ style comments in the kernel.
|