Messages in this thread |  | | Date | Sun, 13 Aug 2017 11:24:14 -0500 | From | "Serge E. Hallyn" <> | Subject | Re: [PATCH 1/4] selinux: Delete eight unnecessary variable assignments |
| |
Quoting Serge E. Hallyn (serge@hallyn.com): > Quoting SF Markus Elfring (elfring@users.sourceforge.net): > > From: Markus Elfring <elfring@users.sourceforge.net> > > Date: Sun, 13 Aug 2017 14:17:48 +0200 > > > > One local variable was reset to zero at the end of these functions. > > This value will also be set by a previous call of a function if it was > > executed successfully. Thus omit an extra assignment there. > > > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > > Acked-by: Serge Hallyn <serge@hallyn.com>
BTW this does add a burden to the maintainers as it makes the code a bit more fragile in the face of future changes. So my ack means it looks ok, but if the maintainers don't want to take it I absolutely understand.
|  |