Messages in this thread |  | | Date | Sun, 13 Aug 2017 07:37:50 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 0/6] constify pci_error_handlers structures |
| |
On Sat, Aug 12, 2017 at 01:51:21PM +0200, Julia Lawall wrote: > Another issue arises in the files drivers/infiniband/hw/hfi1/pcie.c and > drivers/infiniband/hw/qib/qib_pcie.c, where the pci_error_handlers > structure is defined in one file and used in another file. The structure > definition references various functions that are static in the same file. > Should I try to move those functions to the file containing the pci_driver > structure? Or leave the functions where they are and remove the static > annotation?
I'd just leave them as-is and remove the static for now.
|  |