Messages in this thread |  | | Subject | Re: [PATCH v2 2/2] dt-bindings: ata: add DT bindings for MediaTek SATA controller | From | Ryder Lee <> | Date | Fri, 11 Aug 2017 11:57:36 +0800 |
| |
Hi Rob,
Sorry for the noise letter.
On Fri, 2017-08-11 at 10:25 +0800, Ryder Lee wrote: > > > +Required properties: > > > + - compatible : Must be "mediatek,ahci". > > > > SoC specific compatible strings please. > > Okay.
I took a look at ./ahci-platform.txt. Could we just add a generic compatible string as below:
compatible: Must be "mediatek,soc-model-ahci", "mediatek,mtk-ahci"
In doing so, we can avoid having an endless list of compatibles for those MTK SoCs with the same IP block.
> > > + > > > +Optional properties: > > > + - power-domains : A phandle and power domain specifier pair to the power > > > + domain which is responsible for collapsing and restoring > > > + power to the peripheral. > > > + - resets : Must contain an entry for each entry in reset-names. > > > + See ../reset/reset.txt for details. > > > + - reset-names : Associated names must be: "axi", "sw", "reg". > > > + - mediatek,phy-mode : A phandle to the system controller, used to enable > > > + SATA function. > > > + > > > +Example: > > > + > > > + sata: sata@1a200000 { > > > + compatible = "mediatek,ahci";
MT7622 should be: compatible = "mediatek,mt7622-ahci", "mediatek,mtk-ahci";
Ryder
|  |