Messages in this thread |  | | Subject | Re: [PATCH v7 02/15] lib: Add shared copies of some GCC library routines | From | Andy Shevchenko <> | Date | Tue, 01 Aug 2017 16:06:20 +0300 |
| |
On Mon, 2017-07-31 at 17:59 -0700, Palmer Dabbelt wrote: > Many ports (m32r, microblaze, mips, parisc, score, and sparc) use > functionally identical copies of various GCC library routine files, > which came up as we were submitting the RISC-V port (which also uses > some of these). > > This patch adds a new copy of these library routine files, which are > functionally identical to the various other copies. These are > availiable via Kconfig as CONFIG_GENERIC_$ROUTINE, which currently > isn't > used anywhere. >
> Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
That's why we are putting tags before own SoB line(s)
In two cases in the patch you have
+ +
for no reason. I think you may remove second empty line.
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
|  |