lkml.org 
[lkml]   [2017]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subjectblk-mq timeout question
Date
While changing the DASD device driver to use the blk-mq interfaces I 
found the following unexpected behavior:

In case of a timeout our complete callback is never called. Here is the
sequence of events as I understood:

- timeout occurs
- blk_mq_check_expired() calls and checks blk_mark_rq_complete()
- our .timeout callback is called which returns BLK_EH_NOT_HANDLED and
schedules delayed work
- our worker calls blk_mq_complete_request()
- this also checks blk_mark_rq_complete() and therefore never calls our
complete callback

Question:
Should blk_clear_rq_complete() also be called for the BLK_EH_NOT_HANDLED
case?

Regards,
Stefan

\
 
 \ /
  Last update: 2017-07-07 15:47    [W:0.052 / U:2.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site