lkml.org 
[lkml]   [2017]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] pinctrl: sunxi: add support of R40 to A10 pinctrl driver
From


于 2017年7月7日 GMT+08:00 下午5:18:38, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:
>On Fri, Jul 07, 2017 at 07:13:30AM +0800, Icenowy Zheng wrote:
>>
>>
>> 于 2017年7月7日 GMT+08:00 上午4:50:30, Maxime Ripard
><maxime.ripard@free-electrons.com> 写到:
>> >On Thu, Jul 06, 2017 at 10:28:22PM +0800, Icenowy Zheng wrote:
>> >> SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 0),
>> >> SUNXI_FUNCTION(0x0, "gpio_in"),
>> >> SUNXI_FUNCTION(0x1, "gpio_out"),
>> >> - SUNXI_FUNCTION(0x2, "i2c0")), /* SCK */
>> >> + SUNXI_FUNCTION(0x2, "i2c0"), /* SCK */
>> >> + SUNXI_FUNCTION_VARIANT(0x3,
>> >> + "pll_lock_dbg",
>> >> + PINCTRL_SUN8I_R40)),
>> >
>> >You have a number of lines where the wrapping is not consistent with
>> >the rest, such as this one, but also...
>>
>> I think this one is because of extraordinary function name.
>
>Since you don't have a comment, I guess that's not really that bad.

Yes. I tried it and it can fit the space saved by having no comment.

>
>Maxime

\
 
 \ /
  Last update: 2017-07-07 11:22    [W:0.068 / U:4.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site