lkml.org 
[lkml]   [2017]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus
Date
Takashi Iwai <tiwai@suse.de> writes:

> On Tue, 04 Jul 2017 21:37:48 +0200,
> Robert Jarzmik wrote:
>>
>> Takashi Iwai <tiwai@suse.de> writes:
>>
>> > On Fri, 30 Jun 2017 21:43:58 +0200,
>> > Robert Jarzmik wrote:
>> >> +static struct bus_type ac97_bus_type = {
>> >> + .name = "ac97",
>> >
>> > Name-conflict with the old ac97 bus?
>> Yeah, fair point. So what should I choose for this new one ?
>> - ac97new
>> - ac97bis
>> - ac97_2
>> - ac97reborn
>
> ac97bus
> ac97_episode_5
> ac98
> ...
>
> I have no opinion on it.
Ah clone wars one is really tempting :)
But let's have ac97bus actually.

> You can use subsys_init() for modules, it's no problem.
> When it's built for a module, all xxx_init() is handled as equivalent
> with module_init(). See linux/module.h.
>
> It's just the lack of module_exit() in your case.
Got it, I'll add it for v4.

Cheers.

--
Robert

\
 
 \ /
  Last update: 2017-07-05 22:22    [W:0.077 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site