lkml.org 
[lkml]   [2017]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus
Date
Takashi Iwai <tiwai@suse.de> writes:

> On Fri, 30 Jun 2017 21:43:58 +0200,
> Robert Jarzmik wrote:
>> +static struct bus_type ac97_bus_type = {
>> + .name = "ac97",
>
> Name-conflict with the old ac97 bus?
Yeah, fair point. So what should I choose for this new one ?
- ac97new
- ac97bis
- ac97_2
- ac97reborn

>> +static int __init ac97_bus_init(void)
>> +{
>> + return bus_register(&ac97_bus_type);
>> +}
>> +subsys_initcall(ac97_bus_init);
>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_AUTHOR("Robert Jarzmik <robert.jarzmik@free.fr>");
>
> No bus_unregister() at exit?
Mmmh, that's because I used subsys_initcall(), which doesn't look good in a
module compilation setup. That will require a module_init(), and I will think
about how to implement it and test it for next iteration.

Cheers.

--
Robert

\
 
 \ /
  Last update: 2017-07-04 21:38    [W:0.067 / U:17.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site