lkml.org 
[lkml]   [2017]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpiolib: skip unwanted events, don't convert them to opposite edge
2017-07-03 13:07 GMT+02:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
> On Mon, Jul 3, 2017 at 12:12 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>> The previous fix for filtering out of unwatched events was not entirely
>> correct. Instead of skipping the events we don't want, they are now
>> interpreted as events with opposing edge.
>>
>> In order to fix it: always read the GPIO line value on interrupt and
>> only emit the event if it corresponds with the event type we requested.
>
>> struct lineevent_state *le = p;
>> struct gpioevent_data ge;
>> - int ret;
>> + int ret, level;
>
> I prefer
> int level;
> int ret;
>
> Though it's matter of taste (I don't remember which one Linus' preferable).
>
> --
> With Best Regards,
> Andy Shevchenko

Hard to tell, the file uses both styles.

Thanks,
Bartosz

\
 
 \ /
  Last update: 2017-07-04 16:27    [W:0.079 / U:1.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site