Messages in this thread |  | | From | Jinpu Wang <> | Date | Mon, 31 Jul 2017 10:10:20 +0200 | Subject | Re: [PATCH 04/29] scsi: pm8001: constify pci_device_id. |
| |
On Sun, Jul 30, 2017 at 10:37 AM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by <linux/pci.h> work with > const pci_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > drivers/scsi/pm8001/pm8001_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c > index 034b2f7..f2757cc 100644 > --- a/drivers/scsi/pm8001/pm8001_init.c > +++ b/drivers/scsi/pm8001/pm8001_init.c > @@ -1270,7 +1270,7 @@ static int pm8001_pci_resume(struct pci_dev *pdev) > /* update of pci device, vendor id and driver data with > * unique value for each of the controller > */ > -static struct pci_device_id pm8001_pci_table[] = { > +static const struct pci_device_id pm8001_pci_table[] = { > { PCI_VDEVICE(PMC_Sierra, 0x8001), chip_8001 }, > { PCI_VDEVICE(PMC_Sierra, 0x8006), chip_8006 }, > { PCI_VDEVICE(ADAPTEC2, 0x8006), chip_8006 }, > -- > 2.7.4 >
Thanks, Acked-by: Jack Wang <jinpu.wang@profitbricks.com>
-- Jack Wang Linux Kernel Developer
|  |