[lkml]   [2017]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] iio: adc: sun4i-gpadc-iio: fix unbalanced irq enable/disable
On Mon, Jul 03, 2017 at 03:09:26PM +0200, Quentin Schulz wrote:
> When initializing interrupts, the devm_request_any_context_irq will
> enable them right away. An atomic flag was set in sun4i_irq_init and read
> in the interrupt handler to make sure no unwanted interrupts were
> handled. If an unwanted interrupt occurred, the handler would disable
> the irq and return IRQ_HANDLED. However, at the end of sun4i_irq_init,
> the irq would be disabled as well, resulting in an unbalanced enable
> (since there are more disables than enables, the code enabling the
> interrupt would never be called).
> When reading the ADC or the temperature, the respective irq would be
> enabled in the read function and disabled in the irq handler. In the
> read function, we would wait for a completion (with a timeout) that will
> be set in the irq handler. However, if the completion is never set or if
> the wait for completion times out, the irq would not be disabled in the
> read function resulting in an unbalanced enable once the read function
> is called again (since there are 2+ enables for no disable).
> Moving disable_irq from the irq handler to the read function get rid of
> these two cases of unbalanced enable.
> Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC")
> Reported-by: Andreas Färber <>
> Signed-off-by: Quentin Schulz <>

Acked-by: Maxime Ripard <>


Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2017-07-03 23:20    [W:0.046 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site