lkml.org 
[lkml]   [2017]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] zram: constify attribute_group structures.
From
Date
Hi,


On Monday 03 July 2017 11:57 AM, Minchan Kim wrote:
> Hello,
>
> On Mon, Jul 03, 2017 at 11:43:13AM +0530, Arvind Yadav wrote:
>> attribute_groups are not supposed to change at runtime. All functions
>> working with attribute_groups provided by <linux/sysfs.h> work with const
>> attribute_group. So mark the non-const structs as const.
> If so, how about changing all of places where not have used const
> as well as zram?
Sure, I am going to change other place also.
>
> Anyway, I'm okay with this.
>
>> File size before:
>> text data bss dec hex filename
>> 8293 841 4 9138 23b2 drivers/block/zram/zram_drv.o
>>
>> File size After adding 'const':
>> text data bss dec hex filename
>> 8357 777 4 9138 23b2 drivers/block/zram/zram_drv.o
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> Acked-by: Minchan Kim <minchan@kernel.org>
>
> Thanks.
Thanks,
~arvind

\
 
 \ /
  Last update: 2017-07-03 09:19    [W:0.071 / U:2.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site