lkml.org 
[lkml]   [2017]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] dmaengine: qcom_hidma: correct API violation for submit
On Fri, Jun 30, 2017 at 10:43:05AM -0400, Sinan Kaya wrote:
> Current code is violating the DMA Engine API by putting the submitted
> requests directly into the HW queue. This causes queued transactions
> to be started by another thread as soon as the first one finishes.
>
> The DMA Engine document clearly states this.
>
> "dmaengine_submit() will not start the DMA operation".
>
> Move HW queuing of the requests into the issue_pending() routine
> to comply with API requirements also create a new queued state for
> temporarily holding the requests.
>
> A descriptor goes through these transitions now.
>
> free->prepared->queued->active->completed->free
>
> as opposed to
>
> free->prepared->active->completed->free

Applied, thanks

--
~Vinod

\
 
 \ /
  Last update: 2017-07-03 07:08    [W:0.030 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site