lkml.org 
[lkml]   [2017]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] MFD for v4.13
Hi!

> > > > include/linux/mfd/madera/registers.h | 8832 ++++++++++++++++++++
> > >
> > > So I've pulled everything but this, because honestly, that file looks
> > > like utter garbage.
> > >
> > > Why are there all those _hundreds_ of odd defines for
> > >
> > > MADERA_WSEQ_SEQUENCE_xx
> > >
> > > when it looks like you could just do one single one:
> > >
> > > // The sequence is one-based because somebody doesn't
> > > // know that indices start at 0. Thus the "-2".
> > > #define MADERA_WSEQ_SEQUENCE(x) (0x3000 + (x)*2 - 2)
...
> > > (a) probably closer to 200x too many lines
> > > (b) less flexible than doing it right
> > >
> > > Honestly, tell me why would I want to merge something monstrous like that?
> >
> > I'm inclined to agree and had my reservations. However based on
> > a previous conversation [0], I was convinced that it's actually the
> > right thing to do.
> >
> > https://lkml.org/lkml/2017/4/7/229
...
> We really quite like to keep all the registers defined because it
> makes the source highly greppable, which is extremely useful. A
> type of question which is often asked is "what does the driver
> do with register bits XYZ" or "where does it use register
> bits XYZ". Eliminating definitions into generator macros or
> block-indexing code makes these questions more difficult to
> answer. Another convenience is that it makes it easier for people
> to translate raw hardware configurations (which are a list
> of register values) into ALSA and pdata settings if they can

Well, easy grep is a nice thing, but not worth the cost of 8000 lines
vs. 40 lines. I'm sure you can write the required regexps in less than
7960 lines.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-07-24 21:21    [W:0.050 / U:3.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site