lkml.org 
[lkml]   [2017]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 0/9] Introduce housekeeping subsystem
From
Date
On 7/21/2017 9:21 AM, Frederic Weisbecker wrote:
> I'm leaving for two weeks so this is food for thoughts in the meantime :)
>
> We have a design issue with nohz_full: it drives the isolation features
> through the *housekeeping*() functions: kthreads, unpinned timers,
> watchdog, ...
>
> But things should work the other way around because the tick is just an
> isolation feature among others.
>
> So we need a housekeeping subsystem to drive all these isolation
> features, including nohz full in a later iteration. For now this is a
> basic draft. In the long run this subsystem should also drive the tick
> offloading (remove residual 1Hz) and all unbound kthreads.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> nohz/0hz
>
> HEAD: 68e3af1de5db228bf6c2a5e721bce59a02cfc4e1

For the series:

Reviewed-by: Chris Metcalf <cmetcalf@mellanox.com>

I spotted a few typos that you should grep for and fix for your next
version:
"watchog", "Lets/lets" instead of "Let's/let's", "overriden" (should
have two d's).

The new housekeeping=MASK boot option seems like it might make it a little
irritating to specify nohz_full=MASK as well. I guess if setting
NO_HZ_FULL_ALL
implied "all but housekeeping", it becomes a reasonably tidy solution.
To make
this work right you might have to make the housekeeping option early_param
instead so its value is available early enough.

--
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com

\
 
 \ /
  Last update: 2017-07-21 21:48    [W:0.070 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site