lkml.org 
[lkml]   [2017]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 04/12] x86/apic: Move logical APIC ID away from apic_bsp_setup()
From
Date
Hi, Thomas

At 07/03/2017 01:54 AM, Thomas Gleixner wrote:
> On Fri, 30 Jun 2017, Dou Liyang wrote:
>> /*
>> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
>> index 93f0cda..d6721f0 100644
>> --- a/arch/x86/kernel/smpboot.c
>> +++ b/arch/x86/kernel/smpboot.c
>> @@ -1347,8 +1347,11 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus)
>> }
>>
>> default_setup_apic_routing();
>> - cpu0_logical_apicid = apic_bsp_setup(false);
>> -
>> + apic_bsp_setup(false);
>> + if (x2apic_mode)
>> + cpu0_logical_apicid = apic_read(APIC_LDR);
>> + else
>> + cpu0_logical_apicid = GET_APIC_LOGICAL_ID(apic_read(APIC_LDR));
>
> Can you please move that into a seperate helper function?


Yes, it will be a separate helper function in the next version.

Thanks,

dou.

>
>> /* Setup local timer */
>> x86_init.timers.setup_percpu_clockev();
>>
>> --
>> 2.5.5
>>
>>
>>
>>
>
>
>


\
 
 \ /
  Last update: 2017-07-03 04:04    [W:0.055 / U:6.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site