lkml.org 
[lkml]   [2017]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: Add saved_tgids file to show cached pid to tgid mappings
Hi Michael,

[auto build test WARNING on trace/for-next]
[also build test WARNING on next-20170630]
[cannot apply to tip/perf/core linus/master v4.12-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Michael-Sartain/tracing-Add-saved_tgids-file-to-show-cached-pid-to-tgid-mappings/20170702-092448
base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: i386-randconfig-x072-07010433 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

In file included from include/uapi/linux/stddef.h:1:0,
from include/linux/stddef.h:4,
from include/uapi/linux/posix_types.h:4,
from include/uapi/linux/types.h:13,
from include/linux/types.h:5,
from include/linux/mm_types_task.h:10,
from include/linux/mm_types.h:4,
from include/linux/kmemcheck.h:4,
from include/linux/ring_buffer.h:4,
from kernel/trace/trace.c:14:
kernel/trace/trace.c: In function 'saved_cmdlines_next':
kernel/trace/trace.c:4612:22: error: implicit declaration of function 'trace_find_tgid' [-Werror=implicit-function-declaration]
if (tgid_check && !trace_find_tgid(*ptr))
^
include/linux/compiler.h:160:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> kernel/trace/trace.c:4612:3: note: in expansion of macro 'if'
if (tgid_check && !trace_find_tgid(*ptr))
^~
kernel/trace/trace.c: In function 'saved_cmdlines_start':
kernel/trace/trace.c:4627:21: error: 'tgid_map' undeclared (first use in this function)
if (tgid_check && !tgid_map)
^
include/linux/compiler.h:160:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
kernel/trace/trace.c:4627:2: note: in expansion of macro 'if'
if (tgid_check && !tgid_map)
^~
kernel/trace/trace.c:4627:21: note: each undeclared identifier is reported only once for each function it appears in
if (tgid_check && !tgid_map)
^
include/linux/compiler.h:160:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
kernel/trace/trace.c:4627:2: note: in expansion of macro 'if'
if (tgid_check && !tgid_map)
^~
cc1: some warnings being treated as errors

vim +/if +4612 kernel/trace/trace.c

4596 };
4597
4598 static void *saved_cmdlines_next(struct seq_file *m, void *v, loff_t *pos)
4599 {
4600 unsigned int *ptr = v;
4601 long tgid_check = (long) m->private;
4602
4603 if (*pos || m->count)
4604 ptr++;
4605
4606 (*pos)++;
4607
4608 for (; ptr < &savedcmd->map_cmdline_to_pid[savedcmd->cmdline_num];
4609 ptr++) {
4610 if (*ptr == -1 || *ptr == NO_CMDLINE_MAP)
4611 continue;
> 4612 if (tgid_check && !trace_find_tgid(*ptr))
4613 continue;
4614
4615 return ptr;
4616 }
4617
4618 return NULL;
4619 }
4620

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2017-07-02 19:27    [W:0.053 / U:26.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site