lkml.org 
[lkml]   [2017]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] sgi-xp: convert BUG_ONs to WARN_ONs... sheesh
On Fri, Jun 30, 2017 at 12:01 PM, Davidlohr Bueso <dave@stgolabs.net> wrote:
> While going through the driver wake code, I found the
> abuse of BUG_ON to be quite disturbing.

These were coded as BUG_ON to ensure they were addressed. They
do not get raised in any running environment. Switching to WARN_ON
will make it more difficult to determine that a problem has occurred and
with a large system, the details of that failure can easily get buried.

Those are my objections. In reality, they are extremely rare and we can
easily switch these back to BUG_ON() when we are trying out new releases
and live with a WARN_ON() for other instances.

> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Ackd-by: Robin Holt <robinmholt@gmail.com>

\
 
 \ /
  Last update: 2017-06-30 23:15    [W:0.136 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site