lkml.org 
[lkml]   [2017]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 0/5] genirq: Distangle irq_request/release_resources() from irq_desc->lock
From
Date
On 29/06/17 22:33, Thomas Gleixner wrote:
> The irq_request/release_resources() callbacks are a problem on RT as they
> are called under irq_desc->lock with interrupts disabled.
>
> Aside of that calling them under irq_desc->lock is conceptually wrong and
> has a (hard to trigger and probably theoretical) issue in free_irq(). See
> patch 4/5 for a detailed explanation.
>
> The series contains also a fix for the exynos gpio driver, which fiddles
> with the irq masking in the resource callbacks, which is bogus and
> potentially harmful.
>
> Finally it moves the irq timings deallocation out of the spin locked region.
>
> Thanks,
>
> tglx
> ---
> drivers/pinctrl/samsung/pinctrl-exynos.c | 4 --
> include/linux/irqdesc.h | 3 +
> kernel/irq/irqdesc.c | 1
> kernel/irq/manage.c | 47 +++++++++++++++++++------------
> 4 files changed, 34 insertions(+), 21 deletions(-)

For the series:

Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>

M.
--
Jazz is not dead. It just smells funny...

\
 
 \ /
  Last update: 2017-06-30 23:13    [W:0.078 / U:5.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site