Messages in this thread |  | | Date | Wed, 28 Jun 2017 11:57:00 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 1/9] iommu: Introduce bind_pasid_table API function |
| |
On Tue, Jun 27, 2017 at 12:47:55PM -0700, Jacob Pan wrote: > +int iommu_bind_pasid_table(struct iommu_domain *domain, struct device *dev, > + struct pasid_table_info *pasidt_binfo) > +{ > + if (unlikely(!domain->ops->bind_pasid_table)) > + return -EINVAL;
I think its better to return -ENODEV here, like other iommu-api functions do when a callback is NULL.
> +enum iommu_model { > + IOMMU_MODEL_INTEL_VTD, > + IOMMU_MODEL_ARM_SMMU, > +};
AMD IOMMU also supports shared virtual memory.
Regards,
Joerg
|  |