lkml.org 
[lkml]   [2017]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH/RFC 0/4] perf annotate: Add --source-only option and the new source code TUI view
From
Date
Additionally,
the code is available on 'annotate/src-only' branch at

git://github.com/taeung/linux-perf.git

Thanks,
Taeung

On 06/28/2017 12:18 PM, Taeung Song wrote:
> Hi,
>
> The --source-only option and new source code TUI view can show
> the result of performance analysis based on full source code per symbol(function).
> (Namhyung Kim told me this idea and it was also requested by others some time ago..)
>
> If someone wants to see the cause, he/she will need to dig into the asm.
> But before that, looking at the source level can give a hint or clue
> for the problem.
>
> For example, if target symbol is 'hex2u64' of util/util.c,
> the output is like below.
>
> $ perf annotate --source-only --stdio -s hex2u64
> Percent | Source code of util.c for cycles:ppp (42 samples)
> -----------------------------------------------------------------
> 0.00 : 354 * While we find nice hex chars, build a long_val.
> 0.00 : 355 * Return number of chars processed.
> 0.00 : 356 */
> 0.00 : 357 int hex2u64(const char *ptr, u64 *long_val)
> 2.38 : 358 {
> 2.38 : 359 const char *p = ptr;
> 0.00 : 360 *long_val = 0;
> 0.00 : 361
> 30.95 : 362 while (*p) {
> 23.81 : 363 const int hex_val = hex(*p);
> 0.00 : 364
> 14.29 : 365 if (hex_val < 0)
> 0.00 : 366 break;
> 0.00 : 367
> 26.19 : 368 *long_val = (*long_val << 4) | hex_val;
> 0.00 : 369 p++;
> 0.00 : 370 }
> 0.00 : 371
> 0.00 : 372 return p - ptr;
> 0.00 : 373 }
>
> And I added many perf developers into Cc: because I want to listen to your opinions
> about this new feature, if you don't mind.
>
> If you give some feedback, I'd appreciate it! :)
>
> Thanks,
> Taeung
>
> Taeung Song (4):
> perf annotate: Add --source-only option
> perf annotate: Add new source code view to the annotate TUI browser
> perf annotate: Fold or unfold partial disassembly lines on source code
> view
> perf annotate: Support a 'o' key showing addresses on the new source
> code view
>
> tools/perf/builtin-annotate.c | 2 +
> tools/perf/ui/browser.h | 1 +
> tools/perf/ui/browsers/annotate.c | 307 +++++++++++++++++++++++++++++++++++++-
> tools/perf/util/annotate.c | 303 ++++++++++++++++++++++++++++++++++++-
> tools/perf/util/annotate.h | 30 ++++
> tools/perf/util/symbol.c | 1 +
> tools/perf/util/symbol.h | 1 +
> 7 files changed, 633 insertions(+), 12 deletions(-)
>

\
 
 \ /
  Last update: 2017-06-28 05:27    [W:0.099 / U:1.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site