[lkml]   [2017]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v7] Input: psxpad-spi - Add PlayStation 1/2 joypads via SPI interface Driver

On Mon, May 1, 2017 at 9:47 PM, Dmitry Torokhov
<> wrote:
> On Sun, Apr 30, 2017 at 02:11:03PM +0900, Tomohiro Yoshidomi wrote:
>> PlayStation 1/2 joypads can be connected directly to the SPI interface.
>> Signed-off-by: Tomohiro Yoshidomi <>
> Benjamin, David, I think this driver now matches the gamepad spec that
> we have in Drivers/input/gamepad.rst. Could you give it an one-over, as
> far as mappings go, otherwise I think it can be applied and merged with
> my 2nd pull request.

Looks good to me:

Acked-by: David Herrmann <>

The FF code could be select'ed rather than conditional. Everything
else looks fine. I didn't check the SPI internals though. Never
touched SPI, sorry.


 \ /
  Last update: 2017-05-03 13:16    [W:0.204 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site