lkml.org 
[lkml]   [2017]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 00/18] ARM64: meson: DT cleanups
From
Date
Hi Kevin,

Am 17.05.2017 um 23:46 schrieb Kevin Hilman:
> Andreas Färber <afaerber@suse.de> writes:
>> This series fixes several cosmetic issues, on top of your for-next branch.
>>
>> Patches 3-6 rename a node, the rest should all be non-functional changes.
>>
>> PLEASE STOP merging random new nodes at the bottom of DT files!
>> Just like it's a convention to sort new nodes by unit address, it has been
>> a convention to sort by-label nodes by their label. As discussed here and
>> elsewhere, this helps avoid merge conflicts and makes nodes easy to find.
>> I don't care whether we order A0 before A or after, but adding new HDMI
>> or CVBS nodes at the very bottom is totally out of alphabetical order.
>> Since my v1 you really should've known that...
>
> Your tone is a bit tiresome and frankly makes me hesitate before
> reviewing the patches. If you expect cordial dialogue and producitve
> collaboration, please dial the accusations back a notch.

I have sketched the history in another reply, maybe you understand the
sentiments better now.

I was annoyed to see that contributions by several people made the
problem worse than it was originally. I.e., my v1 fix and now v2 grew
more invasive because the issue did not get contained, not just not
fixed. Rebasing this branch was no fun.

[snip]

I will continue to point things out in review or hindsight where I can,
but as explained to Martin, this is not something I can continuously do
in the pace that BayLibre's nice driver contributions have led to.

As for the question of ownership, there should be no doubt that I not
only factually contributed meson-gxbb DT files but also figured out how
to get any kernel to boot on S905 with the old vendor U-Boot and fixed
serial output and added earlycon. That was before BayLibre stepped in.
So from my perspective all your contributions are based on my pioneering
S905 work (and my work in turn reused Carlo's S805 meson_uart etc.), and
I will not react well when some BayLibre employee not initially involved
with those efforts (Neil) now tells me to shut up and pretends as if he
makes the rules now just because his colleague stepped up as maintainer.
The ordering rules I applied here are not my invention but things I
picked on from previous reviews. You yourself had stated that I could
resend the patches and explain why - Russell and I already gave some
reasons, and there were no responses, which I took as no opposition and
was frankly surprised about the renewed level of opposition.

More generally, if a fix makes sense on its own and has no dependencies,
then I personally prefer it getting applied after reviews. If there's a
rule/reason for requiring full-series resends in Linux, it hasn't been
explained to me yet.

Regards,
Andreas

--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

\
 
 \ /
  Last update: 2017-05-20 17:49    [W:0.232 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site