lkml.org 
[lkml]   [2017]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/4] iio: accel: adxl345: Add support for triggered buffer
On Mon, May 01, 2017 at 02:24:27PM +0300, Andy Shevchenko wrote:
[...]
> One nit below.
> FWIW:
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> > +static irqreturn_t adxl345_trigger_handler(int irq, void *p)
> > +{
> > + struct iio_poll_func *pf = p;
> > + struct iio_dev *indio_dev = pf->indio_dev;
> > + struct adxl345_data *data = iio_priv(indio_dev);
> > + int ret;
> > +
> > + mutex_lock(&data->lock);
> > + /* Make sure data is ready when using external trigger */
> > + if (!data->data_ready_trig_on) {
> > + ret = adxl345_data_ready(data);
> > + if (ret < 0)
> > + goto error;
> > + }
> > +
> > + ret = regmap_bulk_read(data->regmap, ADXL345_REG_DATAX0, data->buffer,
> > + sizeof(__le16) * 3);
> > + if (ret < 0)
> > + goto error;
> > +
> > + iio_push_to_buffers_with_timestamp(indio_dev, data->buffer,
> > + pf->timestamp);
>
> > +error:
>
> I would call it 'err_unlock_notify'.
>

OK.

Thanks for the review,
Eva

> > + mutex_unlock(&data->lock);
> > + iio_trigger_notify_done(indio_dev->trig);
> > +
> > + return IRQ_HANDLED;
> > +}
>
> --
> With Best Regards,
> Andy Shevchenko

\
 
 \ /
  Last update: 2017-05-02 14:25    [W:0.111 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site