lkml.org 
[lkml]   [2017]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/7] staging: sm750fb: unifying macro usage and definitions
On Tue, May 16, 2017 at 11:20:18AM +0200, Matej Dujava wrote:
> This patch adds tabs into macro definitions so all rhs are on same column.
> Move MHz macro from ddk_chip.c to ddk_chip.h.
>
> Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 18 ++++----
> drivers/staging/sm750fb/ddk750_chip.h | 5 +-
> drivers/staging/sm750fb/ddk750_display.h | 78 ++++++++++++++++----------------
> drivers/staging/sm750fb/ddk750_hwi2c.c | 4 +-
> drivers/staging/sm750fb/sm750.h | 6 +--
> 5 files changed, 55 insertions(+), 56 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 944dd25..64d0a53 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -5,8 +5,6 @@
> #include "ddk750_chip.h"
> #include "ddk750_power.h"
>
> -#define MHz(x) ((x) * 1000000)
> -
> static logical_chip_type_t chip;
>
> logical_chip_type_t sm750_get_chip_type(void)
> @@ -36,7 +34,7 @@ static unsigned int get_mxclk_freq(void)
> unsigned int M, N, OD, POD;
>
> if (sm750_get_chip_type() == SM750LE)
> - return MHz(130);
> + return MHZ(130);

But MHz makes more sense, don't you think so?

Please leave that as-is.

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-05-18 15:56    [W:0.093 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site