lkml.org 
[lkml]   [2017]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 4/8] gpio: exar: Fix iomap request
On Sat, May 13, 2017 at 10:29 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> The UART driver already maps the resource for us. Trying to do this here
> only fails and leaves us with a non-working device.

I hoped this had been tested previously...
FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> drivers/gpio/gpio-exar.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c
> index 9138ee087c5d..d6ffb3d89b9c 100644
> --- a/drivers/gpio/gpio-exar.c
> +++ b/drivers/gpio/gpio-exar.c
> @@ -128,14 +128,10 @@ static int gpio_exar_probe(struct platform_device *pdev)
> return -ENODEV;
>
> /*
> - * Map the pci device to get the register addresses.
> - * We will need to read and write those registers to control
> - * the GPIO pins.
> - * Using managed functions will save us from unmaping on exit.
> - * As the device is enabled using managed functions by the
> - * UART driver we can also use managed functions here.
> + * The UART driver must have mapped region 0 prior to registering this
> + * device - use it.
> */
> - p = pcim_iomap(pcidev, 0, 0);
> + p = pcim_iomap_table(pcidev)[0];
> if (!p)
> return -ENOMEM;
>
> --
> 2.12.0
>



--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-05-13 15:28    [W:0.116 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site