Messages in this thread |  | | Subject | Re: [PATCH v1] selftests: Make test_harness.h more generally available | From | Shuah Khan <> | Date | Mon, 1 May 2017 13:23:58 -0600 |
| |
On 04/30/2017 12:22 PM, Will Drewry wrote: > On Sun, Apr 30, 2017 at 12:39 PM, Kees Cook <keescook@chromium.org> wrote: >> >> On Sun, Apr 30, 2017 at 5:26 AM, Mickaël Salaün <mic@digikod.net> wrote: >>> The seccomp/test_harness.h file contains useful helpers to build tests. >>> Moving it to the selftest directory should benefit to other test >>> components. >> >> Unless Shuah thinks this should live in a new include/ directory, this >> looks fine to me. >> >> Acked-by: Kees Cook <keescook@chromium.org> > > Same here! > > Acked-by: Will Drewry <wad@chromium.org> > >>
I think the location fine. It will be a good idea to write documentation on how to use this harness. I would recommend rename the file to kselftest_harness.h and a doc file kselftest_harness.txt which will go into Documentation directory.
thanks, - Shuah
|  |