lkml.org 
[lkml]   [2017]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: netfilter: Replace explicit NULL comparisons

On Sunday 2017-04-09 05:42, Arushi Singhal wrote:
>On Sun, Apr 9, 2017 at 1:44 AM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Sat, Apr 08, 2017 at 08:21:56PM +0200, Jan Engelhardt wrote:
> > On Saturday 2017-04-08 19:21, Arushi Singhal wrote:
> >
> > >Replace explicit NULL comparison with ! operator to simplify code.
> >
> > I still wouldn't do this, for the same reason as before. Comparing to
> > NULL explicitly more or less gave an extra guarantee that the other
> > operand was also a pointer.
>
> Arushi, where does it say in the coding style that this is prefered? 
>
>This is reported by checkpatch.pl script.

checkpatch has been controversial at times, like when people took the 80
character limit way too literally. Changing pointer comparisons looks like
another thing that is better left ignored.

\
 
 \ /
  Last update: 2017-04-09 10:27    [W:0.050 / U:0.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site