Messages in this thread |  | | Date | Sat, 8 Apr 2017 11:33:50 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 1/2] leds: Add driver for Qualcomm LPG |
| |
On Fri 2017-04-07 13:36:49, Bjorn Andersson wrote: > On Fri 07 Apr 06:32 PDT 2017, Pavel Machek wrote: > > > > For the patterns I don't know how a trigger for this would look like, > > > how would setting the pattern of a trigger be propagated down to the > > > hardware? > > > > Well... I'm not sure if we _want_ to do triggers for > > patterns. LED triggers change rather quickly (100 times a second?) so > > doing them in kernel makes sense. Patterns take 10s of seconds, so we > > do not need to handle them in kernel. > > > > On any current Qualcomm based phone (using the Qualcomm PMIC to drive > the RGB notification LED) the patterns are hard coded in DeviceTree and > the option you have in runtime is to enable/disable the usage of the > configured pattern and a few knobs of how to traverse the configured > pattern.
Yes... that's easy, but I believe too limiting. Users will want to configure their own patterns for their own events.
> When you enter e.g. a low-battery scenario you trigger the red LED to > run its low-battery-pattern and you don't touch it until there's a > higher prio notification (e.g. someone connects the charger).
Yes, I have something like that, too.
https://gitlab.com/tui/tui/blob/master/ofone/watchdog.py
Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] |  |