[lkml]   [2017]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] Add support for OneWire (W1) devices family 0x26 (MAX17211/MAX17215)

>> Slave device provide software layer for access to internal registers
>> MAX17211/MAX17215 chip.
> Please convert this to regmap.There is no generic w1 handler, but you can provide custom
> read/write functions.
I think regmap be overkill for this driver. Here we need access to a
small number of registers. Registers are extremely simple on the
internal device. As a result, the software layer of regmap will only
complicate the readability and understanding of the code. And also
increase the size and time of code execution, and even complicate the

> Also it would be nice to have this
> based on Then everything
> could go into the power-supply driver.
No problems. Once this set of patches will be accepted in the mainline.


 \ /
  Last update: 2017-04-30 07:25    [W:0.051 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site