Messages in this thread |  | | Subject | Re: [PATCH 1/2] Add support for OneWire (W1) devices family 0x26 (MAX17211/MAX17215) | From | "Alex A. Mihaylov" <> | Date | Sun, 30 Apr 2017 08:21:51 +0300 |
| |
Hi,
>> Slave device provide software layer for access to internal registers >> MAX17211/MAX17215 chip. > Please convert this to regmap.There is no generic w1 handler, but you can provide custom > read/write functions. I think regmap be overkill for this driver. Here we need access to a small number of registers. Registers are extremely simple on the internal device. As a result, the software layer of regmap will only complicate the readability and understanding of the code. And also increase the size and time of code execution, and even complicate the perception.
> Also it would be nice to have this > based on https://lkml.org/lkml/2017/3/16/604. Then everything > could go into the power-supply driver. > No problems. Once this set of patches will be accepted in the mainline.
Alex.
|  |