lkml.org 
[lkml]   [2017]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: rtl8723bs: declare private function as static
From
Date
Hi,

On 23-04-17 19:37, Kenneth Hsu wrote:
> This fixes a sparse warning regarding an undeclared symbol. Since the
> function is private to rtw_recv.c, it should be declared as static.
>
> Signed-off-by: Kenneth Hsu <kennethhsu@gmail.com>

Looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 74e11948c015..695a5c958c80 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1717,7 +1717,8 @@ sint wlanhdr_to_ethhdr(union recv_frame *precvframe)
> }
>
> /* perform defrag */
> -union recv_frame *recvframe_defrag(struct adapter *adapter, struct __queue *defrag_q)
> +static union recv_frame *recvframe_defrag(struct adapter *adapter,
> + struct __queue *defrag_q)
> {
> struct list_head *plist, *phead;
> u8 *data, wlanhdr_offset;
>

\
 
 \ /
  Last update: 2017-04-30 21:09    [W:0.034 / U:1.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site