Messages in this thread |  | | Subject | Re: [PATCH 1/1] staging: comedi: use __func__ instead of hardcoded function name | From | Joe Perches <> | Date | Sat, 29 Apr 2017 10:21:33 -0700 |
| |
On Sat, 2017-04-29 at 22:17 +0530, Dhiru Kholia wrote: > This coding style issue was found by checkpatch.pl script. Using > __func__ instead of hardcoded function name should help in future > refactoring of this code. > > Signed-off-by: Dhiru Kholia <dhiru.kholia@gmail.com> > --- > drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c > index 802f51e..ea194aa 100644 > --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c > +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c > @@ -248,7 +248,7 @@ static irqreturn_t daqp_interrupt(int irq, void *dev_id) > > if (loop_limit <= 0) { > dev_warn(dev->class_dev, > - "loop_limit reached in daqp_interrupt()\n"); > + "loop_limit reached in %s()\n", __func__);
More common would be: dev_warn(dev->class_dev, "%s: loop limit reached\n", __func__);
It also seems that the loop_limit test, a loop count, is sensitive on the cpu frequency and perhaps should be some timer based limit instead.
|  |