Messages in this thread |  | | Date | Sat, 15 Apr 2017 19:01:07 +0200 | From | Thomas Gleixner <> | Subject | [patch 00/20] cpu/hotplug: Convert get_online_cpus() to a percpu_rwsem |
| |
get_online_cpus() is used in hot pathes in mainline and even more so in RT. That can show up badly under certain conditions because every locker contends on a global mutex. RT has it's own homebrewn mitigation which is an (badly done) open coded implementation of percpu_rwsems with recursion support.
The proper replacement for that are percpu_rwsems, but that requires to remove recursion support.
The conversion unearthed real locking issues which were previously not visible because the get_online_cpus() lockdep annotation was implemented with recursion support which prevents lockdep from tracking full dependency chains. These potential deadlocks are not related to recursive calls, they trigger on the first invocation because lockdep now has the full dependency chains available.
The following patch series addresses this by
- Cleaning up places which call get_online_cpus() nested
- Replacing a few instances with cpu_hotplug_disable() to prevent circular locking dependencies.
The series depends on
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core plus Linus tree merged in to avoid conflicts
It's available in git from
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.hotplug
Thanks,
tglx
------- arch/arm/kernel/hw_breakpoint.c | 5 arch/powerpc/kvm/book3s_hv.c | 8 - arch/powerpc/platforms/powernv/subcore.c | 2 arch/s390/kernel/time.c | 2 arch/x86/events/core.c | 1 arch/x86/events/intel/core.c | 4 arch/x86/events/intel/cqm.c | 12 +- arch/x86/kernel/cpu/mtrr/main.c | 2 drivers/acpi/processor_driver.c | 4 drivers/cpufreq/cpufreq.c | 9 - drivers/hwtracing/coresight/coresight-etm3x.c | 12 +- drivers/hwtracing/coresight/coresight-etm4x.c | 12 +- drivers/pci/pci-driver.c | 46 ++++---- include/linux/cpuhotplug.h | 29 +++++ include/linux/padata.h | 3 include/linux/pci.h | 1 include/linux/stop_machine.h | 26 ++++ kernel/cpu.c | 149 +++++++------------------- kernel/padata.c | 38 +++--- kernel/stop_machine.c | 4 20 files changed, 177 insertions(+), 192 deletions(-)
|  |