Messages in this thread |  | | Subject | Re: regulator: s2mps11: Use kcalloc() in s2mps11_pmic_probe() | From | SF Markus Elfring <> | Date | Sat, 15 Apr 2017 19:29:23 +0200 |
| |
>> A multiplication for the size determination of a memory allocation >> indicated that an array data structure should be processed. >> Thus use the corresponding function "kcalloc". >> >> This issue was detected by using the Coccinelle software. > > Unfortunately you write mostly cryptic commit messages.
Thanks for your feedback.
> This does not answer for the main question - why this change is needed.
My update suggestion affects an aspect for the coding style.
> Code looks okay,
There can be different opinions about related implementation details.
> but you should explain in simple words why this is needed.
Do you find the following wording from the script “checkpatch.pl” better to understand?
WARNING: Prefer kcalloc over kzalloc with multiply
Regards, Markus
|  |