[lkml]   [2017]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: regulator: s2mps11: Use kcalloc() in s2mps11_pmic_probe()
>> A multiplication for the size determination of a memory allocation
>> indicated that an array data structure should be processed.
>> Thus use the corresponding function "kcalloc".
>> This issue was detected by using the Coccinelle software.
> Unfortunately you write mostly cryptic commit messages.

Thanks for your feedback.

> This does not answer for the main question - why this change is needed.

My update suggestion affects an aspect for the coding style.

> Code looks okay,

There can be different opinions about related implementation details.

> but you should explain in simple words why this is needed.

Do you find the following wording from the script “”
better to understand?

WARNING: Prefer kcalloc over kzalloc with multiply


 \ /
  Last update: 2017-04-15 19:30    [W:0.024 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site