[lkml]   [2017]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts
On Thu, 2 Feb 2017 11:02:57 +0900
Sergey Senozhatsky <> wrote:

> On (02/01/17 11:37), Steven Rostedt wrote:
> > This looks fine, but I'm curious if you tested it. That is, added a
> > bunch of printks to overflow the buffer. IIRC, I did it to the original
> > nmi code. If you haven't you may want to just to make sure it works. I
> > can also test it too if I get some time.
> Hello Steven,
> yes, I have tested it on my x86 box.

Please note how you tested it in your change log. It's not really a
requirement, and you don't really have to do it. But it helps people
have warm fuzzies about the code. I'm trying to do this in the future
in my own work too.

-- Steve

 \ /
  Last update: 2017-02-02 15:34    [W:1.462 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site